-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable warnings as errors for weekly run in test suite #6217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left a bunch of suggestions. I would also suggest adding a pull_request
trigger to the workflow once it's reasonably complete so you can test it out in action before the PR gets merged.
…lane into tests/warning_as_error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6217 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 457 457
Lines 43413 43413
=======================================
Hits 43109 43109
Misses 304 304 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to GitHub docs fail-fast is a boolean requiring true/false!
Scratch that, this holds true for the current logic in this PR
Co-authored-by: Rashid N H M <[email protected]>
Co-authored-by: Rashid N H M <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the work on this!
Just a note, the accepted suggestions have broken large parts of the action. I intend to roll back to a previous working version, albeit with a more verbose content. |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
doc/releases/changelog-dev.md
file, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint
, and thenrun
pylint pennylane/path/to/file.py
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: This PR enables a weekly run of the test suite with Python-level warnings promoted to errors (exceptions). This will allow the test suite to regularly report when hitting warnings through general execution.
Description of the Change: Add a new workflow to run the test suite with Python warnings as errors on a weekly basis,
Benefits: Enable us to catch warnings when and where they occur during testing.
Possible Drawbacks: Additional overhead of running the CI at the intended occurrence.
Related GitHub Issues: