Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation of quantum_fisher #6074

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Update documentation of quantum_fisher #6074

merged 5 commits into from
Aug 7, 2024

Conversation

dwierichs
Copy link
Contributor

Context:
The documentation of qinfo.quantum_fisher was not quite precise on when adjoint_metric_tensor is being used (successfully), and did not mention potential auxiliary wire requirements.

Description of the Change:
Make the criterion on using default.qubit precise (because we catch other devices), and mention that for other settings, an auxiliary wire may be required.

Benefits:

Possible Drawbacks:

Related GitHub Issues:
#6059
[sc-70300]

@dwierichs dwierichs requested a review from trbromley August 6, 2024 10:01
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (0ffd5d0) to head (ddc9bc8).
Report is 294 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6074      +/-   ##
==========================================
- Coverage   99.66%   99.66%   -0.01%     
==========================================
  Files         430      430              
  Lines       41786    41489     -297     
==========================================
- Hits        41648    41349     -299     
- Misses        138      140       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwierichs dwierichs merged commit f2a558a into master Aug 7, 2024
40 checks passed
@dwierichs dwierichs deleted the doc-fix-qfi branch August 7, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants