Bugfix: Cannot initialize ParticleConservingU1/2 with default init_state
#5535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5535 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 406 406
Lines 37928 37639 -289
==========================================
- Hits 37804 37514 -290
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
dwierichs
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Looks good to me, thanks for the fix, @PietropaoloFrisoni
Would there be any benefit in creating a numpy array directly, rather than a tuple, as the default value? Either way works for me.
@dwierichs That's what I did at first (see this commit), but I ended up changing my mind since the initial state is then converted to a tuple anyway |
…github.com/PennyLaneAI/pennylane into Bugfix/Initializing_ParticleConservingU1/2
PietropaoloFrisoni
deleted the
Bugfix/Initializing_ParticleConservingU1/2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
qml.ParticleConservingU1andqml.ParticleConservingU2cannot be initialized with their default value for theinitial_stateargument (the default value isNone).Description of the Change: If the
initial_stateargument is not specified, it is set to a tuple of zeros, which seems a reasonable choice for an initial state in physics. This modification occurs only if the initial state is not specified and the information is reported in the class's docstring.Benefits: The error is no longer raised when the initial state is not specified, and the class works with the default argument.
Possible Drawbacks: As mentioned above, this modification only occurs if the initial state is not specified and should not cause any issues.
Related GitHub Issues: #5522
[sc-61431]