Update device tests to work with Lightning devices #5518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
|
[sc-61419] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5518 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 404 404
Lines 37852 37561 -291
==========================================
- Hits 37728 37436 -292
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
mlxd
reviewed
Apr 15, 2024
albi3ro
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
I'm approving this now because it's blocking lightning, but we should update validate_diff_method to actually check dev.supports_derivatives instead of adding a lightning patch. Otherwise we will keep trying to test backprop against devices that don't support it.
|
@albi3ro I've made the suggested changes. |
albi3ro
approved these changes
Apr 15, 2024
|
@mudit2812 was this intended to fix #5519? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new tests added to the device test suite weren't totally compatible with lightning devices. I've updated the failing tests to work now. The tensorflow tests failed because our execution pipeline with tensorflow doesn't correctly respect the dtypes, which is a larger issue for us to resolve, so it will be handled in a different PR. For now I've skipped the failing tests.