-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove op.is_hermitian
check in expval, counts, sample to allow jit tracing
#5506
Conversation
Hello. You may have forgotten to update the changelog!
|
…o removeishermitian
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5506 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 404 404
Lines 37833 37555 -278
==========================================
- Hits 37709 37430 -279
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change!
…nnylane into removeishermitian
…o removeishermitian
Solves #5505 and also fixes the same issue in catalyst
tldr: The
is_hermitian
check is breaking jit-compilation