dequeue ops in Hamiltonian.__matmul__
#5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Apr 1, 2024
lillian542
approved these changes
Apr 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5455 +/- ##
==========================================
- Coverage 99.68% 99.67% -0.01%
==========================================
Files 402 402
Lines 37534 37253 -281
==========================================
- Hits 37414 37132 -282
- Misses 120 121 +1 ☔ View full report in Codecov by Sentry. |
trbromley
reviewed
Apr 2, 2024
| @@ -291,6 +291,9 @@ | |||
|
|
|||
| <h3>Bug fixes 🐛</h3> | |||
|
|
|||
| * Using `@` with legacy Hamiltonian instances now properly de-queues the previously existing operations. | |||
There was a problem hiding this comment.
What happens in the new-op-arithmetic setting?
There was a problem hiding this comment.
Things are properly de-queued.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
A user was encountering issues where operations were remaining in the circuit after being used to construct a hamiltonian.
Description of the Change:
De-queue the arguments to
Hamiltonian.__matmul__Benefits:
No more things in the circuit that shouldn't be in the circuit.
Possible Drawbacks:
Related GitHub Issues:
Fixes #5454 [sc-60158]