-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pauli_rep
to compute qml.matrix() whenever possible
#5392
+9
−3
Closed
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
ff3e6ea
Updated condition for swapping matmul order
mudit2812 08b681e
Added tests
mudit2812 b1c4391
use pauli rep for computing matrix of Sum
Qottmann a90a15b
[ci skip]
Qottmann 8a78e44
black formatting
Qottmann 98202cf
black formatting
Qottmann a6a5de0
Merge branch 'master' of https://github.com/PennyLaneAI/pennylane int…
Qottmann bc04197
changelog
Qottmann 0c359f5
Merge branch 'master' into summatrix
Qottmann d43fc1d
Merge branch 'master' of https://github.com/PennyLaneAI/pennylane int…
Qottmann c5b869f
upgrade qml.matrix
Qottmann 7e2b7f3
black formatting
Qottmann 88f746e
remove changes to matrix
Qottmann 93b3ac2
Merge branch 'pauli-swap-order' of https://github.com/PennyLaneAI/pen…
Qottmann 54f642b
branch off mudits PR
Qottmann 86bb86b
Merge branch 'master' of https://github.com/PennyLaneAI/pennylane int…
Qottmann 9580c13
merge
Qottmann 7b317db
bugfix
Qottmann e77a606
Merge branch 'master' of https://github.com/PennyLaneAI/pennylane int…
Qottmann c063fbb
[ci skip]
Qottmann d4ddba2
Merge branch 'master' into pauli-swap-order
mudit2812 58efe4c
[skip ci] Skip CI
mudit2812 56111e4
Merge branch 'master' into pauli-swap-order
mudit2812 4786179
[skip ci] Skip CI
mudit2812 e4cb275
Merge branch 'master' into pauli-swap-order
mudit2812 d209151
Merge branch 'master' into pauli-swap-order
mudit2812 743996e
Merge branch 'master' into pauli-swap-order
mudit2812 64af1ca
Fixed failing tests
mudit2812 6f16caa
Trigger CI
mudit2812 a618920
Updated qasm test
mudit2812 60bb55e
Merge branch 'master' into pauli-swap-order
mudit2812 50f8ae6
Merge branch 'pauli-swap-order' into summatrix
mudit2812 cbc3cad
remove commented code
Qottmann 4bc3072
merge
Qottmann 460243f
merge changelog
Qottmann 2d76378
merge
Qottmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is CSR what we want to use for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context, this came up in switching to new opmath because some generators and qchem operators where now slower in computing
qml.matrix()
, as they were no longerops.Hamiltonian
instances and therefore didnt hit theop.sparse_matrix(..).toarray()
method below anymore. The idea was to just allow still doing that via the pauli rep in this PR; but as @albi3ro pointed out this breaks differentiability. Afaik christina has been cooking up an alternate solution 👩🍳