-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
globalphase decomposes to nothing #4855
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmysilv
commented
Nov 17, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4855 +/- ##
==========================================
- Coverage 99.65% 99.64% -0.01%
==========================================
Files 383 383
Lines 34513 34258 -255
==========================================
- Hits 34393 34137 -256
- Misses 120 121 +1 ☔ View full report in Codecov by Sentry. |
albi3ro
reviewed
Nov 20, 2023
albi3ro
approved these changes
Nov 20, 2023
trbromley
reviewed
Nov 20, 2023
Co-authored-by: Tom Bromley <[email protected]>
mudit2812
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
GlobalPhase is a relatively new operator, and some plugins may not be able to handle it. To be consistent with the pre-GlobalPhase days, I'm making it decompose to nothing so devices will decompose it and make it disappear.
Description of the Change:
Implement
GlobalPhase.compute_decomposition
so it decomposes to nothingBenefits:
Plugins won't break if they see it. It does have a matrix defined, but maybe some plugins need a whitelist of operators.
Possible Drawbacks:
Maybe plugins should fail if they see it, and maybe that's what we wanted?
Related GitHub Issues:
Good to merge with/before #4666
[sc-50428]