Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform doc] Separate qcut #4819

Merged
merged 30 commits into from
Nov 28, 2023
Merged

[Transform doc] Separate qcut #4819

merged 30 commits into from
Nov 28, 2023

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Nov 10, 2023 •
edited
Loading

Context:
We want to make sure that qcut has a good place in the documentation and in PennyLane.

Description of the Change:

  • qcut has its own folder
  • qcut appears in API doc
  • remove qcut.py file
  • rename montecarlo.py to cutcircuit_mc.py

Benefits:
Better visibility of qcut (both in the project and in the docs).

@github-actions GitHub Actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@rmoyard rmoyard added the ci:run-full-test-suite Run the full test-suite on the pull request label Nov 10, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7cb7b7a) 99.65% compared to head (657f8e5) 99.65%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4819      +/-   ##
==========================================
- Coverage   99.65%   99.65%   -0.01%     
==========================================
  Files         388      387       -1     
  Lines       34964    34957       -7     
==========================================
- Hits        34844    34837       -7     
  Misses        120      120

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmoyard rmoyard requested a review from trbromley November 13, 2023 22:37
@trbromley trbromley requested a review from BM7878 November 13, 2023 22:41
trbromley
trbromley approved these changes Nov 14, 2023
View reviewed changes
pennylane/qcut/__init__.py Outdated Show resolved Hide resolved
pennylane/qcut/utils.py Show resolved Hide resolved
josh146
josh146 requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @rmoyard! Left some suggestions to make it a bit more consistent with the other module documentation pages for 'auxiliary functionality'.

doc/code/qml_qcut.rst Outdated Show resolved Hide resolved
pennylane/qcut/__init__.py Show resolved Hide resolved
pennylane/qcut/__init__.py Outdated Show resolved Hide resolved
pennylane/qcut/__init__.py Outdated Show resolved Hide resolved
pennylane/qcut/__init__.py Show resolved Hide resolved
pennylane/qcut/__init__.py Show resolved Hide resolved
rmoyard and others added 11 commits November 27, 2023 09:41
@rmoyard rmoyard requested a review from trbromley November 27, 2023 16:38
trbromley
trbromley approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josh146 @rmoyard!

pennylane/qcut/__init__.py Outdated Show resolved Hide resolved
pennylane/qcut/__init__.py Outdated Show resolved Hide resolved
pennylane/qcut/__init__.py Outdated Show resolved Hide resolved
pennylane/qcut/__init__.py Show resolved Hide resolved
josh146
josh146 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @trbromley @rmoyard!

@rmoyard rmoyard enabled auto-merge (squash) November 27, 2023 21:41
@rmoyard rmoyard disabled auto-merge November 27, 2023 21:42
@rmoyard rmoyard enabled auto-merge (squash) November 27, 2023 21:46
@rmoyard rmoyard requested a review from albi3ro November 28, 2023 18:22
@rmoyard rmoyard merged commit 9781f11 into master Nov 28, 2023
50 checks passed
@rmoyard rmoyard deleted the separate_qcut branch November 28, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trbromley trbromley trbromley approved these changes

@josh146 josh146 josh146 approved these changes

@BM7878 BM7878 Awaiting requested review from BM7878

@albi3ro albi3ro Awaiting requested review from albi3ro

Assignees
No one assigned
Labels
ci:run-full-test-suite Run the full test-suite on the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmoyard @josh146 @trbromley