-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create a PL-specific deprecation warning #4814
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I like this change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4814 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.01%
==========================================
Files 381 381
Lines 34382 34123 -259
==========================================
- Hits 34260 34000 -260
- Misses 122 123 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding a changelog entry, probably under deprecations, and a comment at the top of deprecations.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should potentially have a follow up PR that adds the pytest.ini
change to PennyLane itself, but that may take a bunch of test changes.
Hopefully this will make deprecations much cleaner 👍
How will this change affect the user?
|
Context:
When we deprecate features, it's hard to identify that we've done it.
Description of the Change:
Replace all deprecation warning categories with the new
PennyLaneDeprecationWarning
Benefits:
We can add a pytest.ini filter to make this into failures on plugins!
(I ran a test locally with a plugin that was setting
Observable.return_type
and saw that it raised the error)Possible Drawbacks:
N/A