Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks CI #4741

Merged
merged 131 commits into from
Nov 22, 2023
Merged

Add benchmarks CI #4741

merged 131 commits into from
Nov 22, 2023

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Oct 26, 2023

Context:

The PennyLane test suite currently hits almost all areas of the code base (~100% coverage). Since all areas of the codebase can be tested, these tests are in a good place to collect benchmarking data of the respective tested functions.

Description of the Change:

The CI was updated to include a new benchmarks pipeline hybridized through our tests pipeline.
The benchmarks CI will be triggered in a Pull request if the label ci:run-benchmarks is selected and on a schedule.
The benchmark logs will be uploaded as artifacts, for further analyses.

Benefits:

Benchmark automation

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@AmintorDusko AmintorDusko added the ci:run-benchmarks Run a selected set of benchmarks label Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c025b98) 99.65% compared to head (7609673) 99.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4741      +/-   ##
==========================================
- Coverage   99.65%   99.64%   -0.01%     
==========================================
  Files         383      383              
  Lines       34523    34263     -260     
==========================================
- Hits        34403    34142     -261     
- Misses        120      121       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from add-pytest-benchmarks to master October 26, 2023 19:29
.github/workflows/unit-test.yml Outdated Show resolved Hide resolved
.github/workflows/unit-test.yml Outdated Show resolved Hide resolved
.github/workflows/benchmarks.yml Show resolved Hide resolved
.github/workflows/benchmarks.yml Show resolved Hide resolved
.github/workflows/benchmarks.yml Outdated Show resolved Hide resolved
.github/workflows/unit-test.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I'll let Rashid give the final ok

@AmintorDusko
Copy link
Contributor Author

[sc-38767]

Copy link
Contributor

@rashidnhm rashidnhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AmintorDusko
Copy link
Contributor Author

@trbromley and @mlxd, this PR is ready to merge. Let me know if you have any thoughts on that.

@AmintorDusko AmintorDusko merged commit 4c38adf into master Nov 22, 2023
74 checks passed
@AmintorDusko AmintorDusko deleted the add-pytest-benchmarks-CI branch November 22, 2023 14:49
AmintorDusko added a commit that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:run-benchmarks Run a selected set of benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants