CosineWindow StatePrep
#4683
Merged
CosineWindow StatePrep
#4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4683 +/- ##
=========================================
Coverage ? 99.64%
=========================================
Files ? 381
Lines ? 34052
Branches ? 0
=========================================
Hits ? 33930
Misses ? 122
Partials ? 0
☔ View full report in Codecov by Sentry. |
trbromley
reviewed
Oct 17, 2023
KetpuntoG
added
the
review-ready 👌
|
[sc-45845] |
soranjh
reviewed
Oct 18, 2023
Co-authored-by: soranjh <[email protected]>
Co-authored-by: soranjh <[email protected]>
soranjh
reviewed
Oct 18, 2023
soranjh
reviewed
Oct 20, 2023
soranjh
reviewed
Oct 20, 2023
soranjh
reviewed
Oct 20, 2023
soranjh
reviewed
Oct 20, 2023
soranjh
reviewed
Oct 20, 2023
soranjh
reviewed
Oct 20, 2023
soranjh
reviewed
Oct 20, 2023
There was a problem hiding this comment.
Thanks @KetpuntoG, will approve when my minor comments are addressed.
Co-authored-by: soranjh <[email protected]>
Co-authored-by: soranjh <[email protected]>
Co-authored-by: soranjh <[email protected]>
soranjh
approved these changes
Oct 20, 2023
Jaybsoni
reviewed
Oct 20, 2023
Jaybsoni
reviewed
Oct 20, 2023
Jaybsoni
approved these changes
Oct 20, 2023
Co-authored-by: Jay Soni <[email protected]>
Co-authored-by: Jay Soni <[email protected]>
|
@mudit2812 ready to merge 🚀 |
KetpuntoG
added
the
merge-ready ✔️
KetpuntoG
removed
the
review-ready 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of the cosine window, a state whose vector is equivalent to the cosine function:
notes to the reviewer
Instead of the template mentioned in the PRD:
This other one has been used:
This is because in the paper from which it was extracted, it worked with basic states from$-|N/2\rangle$ to $|N/2-1\rangle$ and we work with states from $|0\rangle$ to $|N-1\rangle$ . so I have made some adjustments to the rotations to adapt it.