Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump JAX version #4680

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Bump JAX version #4680

merged 3 commits into from
Oct 17, 2023

Conversation

lillian542
Copy link
Contributor

@lillian542 lillian542 commented Oct 16, 2023 •
edited
Loading

update JAX to 0.4.18

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b45f808) 99.64% compared to head (c1e35fb) 99.64%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4680   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         376      376           
  Lines       33833    33833           
=======================================
  Hits        33712    33712           
  Misses        121      121

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lillian542 lillian542 marked this pull request as ready for review October 16, 2023 16:04
mudit2812
mudit2812 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@lillian542
Copy link
Contributor Author

[sc-47802]

@Alex-Preciado
Copy link
Contributor

Looks good!! 😎

@mudit2812 mudit2812 added this to the v0.33 milestone Oct 17, 2023
@lillian542 lillian542 enabled auto-merge (squash) October 17, 2023 17:11
@lillian542 lillian542 merged commit 21ec4d4 into master Oct 17, 2023
38 checks passed
@lillian542 lillian542 deleted the bump-jax-version branch October 17, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-Preciado Alex-Preciado Alex-Preciado approved these changes

@mudit2812 mudit2812 mudit2812 approved these changes

@rmoyard rmoyard Awaiting requested review from rmoyard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.33
Development

Successfully merging this pull request may close these issues.
3 participants
@lillian542 @Alex-Preciado @mudit2812