Add TrotterProduct template
#4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaybsoni
changed the title
TrotterProduct templateTrotterProduct template
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4661 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 376 377 +1
Lines 33788 33846 +58
=======================================
+ Hits 33667 33725 +58
Misses 121 121
☔ View full report in Codecov by Sentry. |
|
[sc-44302] |
Jaybsoni
commented
Oct 11, 2023
KetpuntoG
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Awesome job here! 😊
I've left out some silly questions but it's been a long time since I've done a code review and I want to understand some of the decisions. On the other hand, is there still a way to include the differentiability part? I have not been able to obtain the gradient with respect to time
trbromley
reviewed
Oct 11, 2023
Jaybsoni
changed the title
TrotterProduct templateTrotterProduct template
Jaybsoni
added
review-ready 👌
trbromley
reviewed
Oct 12, 2023
trbromley
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Note that @isaacdevlugt has already added a changelog entry here, so no need to worry too much on that point.
trbromley
reviewed
Oct 18, 2023
**Context:** This PR adds additional tests to the `TrotterProduct` class to ensure it integrates well with all interfaces and is fully differentiable. **Description of the Change:** - Add tests for interface execution - Add tests for interface gradient computation --------- Co-authored-by: soranjh <[email protected]>
Jaybsoni
commented
Oct 18, 2023
Jaybsoni
commented
Oct 18, 2023
Jaybsoni
commented
Oct 18, 2023
Jaybsoni
commented
Oct 18, 2023
Jaybsoni
commented
Oct 18, 2023
soranjh
reviewed
Oct 18, 2023
soranjh
reviewed
Oct 19, 2023
trbromley
approved these changes
Oct 19, 2023
Co-authored-by: Tom Bromley <[email protected]>
mudit2812
pushed a commit
that referenced
this pull request
Oct 20, 2023
**Context:** First of 3 PRs adding the new TrotterProduct template to allow for advanced Trotter methods in Pennylane **Description of the Change:** - Implement the template - Add basic tests --------- Co-authored-by: Tom Bromley <[email protected]> Co-authored-by: soranjh <[email protected]> Co-authored-by: soranjh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
First of 3 PRs adding the new TrotterProduct template to allow for advanced Trotter methods in Pennylane
Description of the Change: