Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torch boundary uses JacobianProductCalculator #4654

Merged
merged 122 commits into from
Nov 13, 2023
Merged

Torch boundary uses JacobianProductCalculator #4654

merged 122 commits into from
Nov 13, 2023

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Oct 5, 2023 •
edited
Loading

This PR is a follow on to #4557 .

It updates the torch interface to rely on the JacobianProductCalculator class to compute vjp's.

Note: I cannot figure out how to replicate the failing test locally. It's finite shots, which always makes me a bit suspect. But passes fine locally 😕

albi3ro and others added 30 commits August 2, 2023 16:11
@albi3ro
add jacobianproductcalculator base class and TransformDerivatives
922625e
@albi3ro
add JacobianProductCalculator and TransformDerivatives
94f1f38
@albi3ro
Merge branch 'master' into jacobian_product_class
e8bb908
@albi3ro
Update pennylane/interfaces/jacobian_products.py
b5246a2
@albi3ro
add tests
82fe7d6
@albi3ro
Merge branch 'master' into jacobian_product_class
9ac16a9
@albi3ro
Update doc/releases/changelog-dev.md
ba8a498
@albi3ro
Update pennylane/interfaces/jacobian_products.py
9de89a4
@albi3ro
Apply suggestions from code review
a2ab25e
@albi3ro
experimental device jps
12f5606
@albi3ro
add tests for differentiability and jitting
8e663d6
@albi3ro @dwierichs
Update pennylane/gradients/jvp.py
5f350e1 
Co-authored-by: David Wierichs <[email protected]>
@albi3ro
device derivatives and jacobian products
66356ce
@albi3ro
some more documentation and testing
6b67bf7
@albi3ro
some minor updates
550e1df
@albi3ro @dwierichs
Update pennylane/interfaces/jacobian_products.py
763652f 
Co-authored-by: David Wierichs <[email protected]>
@albi3ro @dwierichs
Apply suggestions from code review
a531ca5 
Co-authored-by: David Wierichs <[email protected]>
@albi3ro
Merge branch 'master' into jacobian_product_class
6c3cf0a
@albi3ro
update docstrings
7dedb4f
@albi3ro
update name in init
0bc9474
@albi3ro
logging and some comments
0289fae
@albi3ro
minor documentation changes
1ee2b90
@albi3ro @dwierichs
Apply suggestions from code review
4c92e0c 
Co-authored-by: David Wierichs <[email protected]>
@albi3ro @dwierichs
[skip-ci] Apply suggestions from code review
7aec029 
Co-authored-by: David Wierichs <[email protected]>
@albi3ro
mvp for device jacobian products [skip-ci]
9cf4686
@albi3ro
Merge branch 'jacobian_product_class' into jpc-devices
e89693b
@albi3ro
integrating jpcs with autograd
c025f65
@albi3ro
Merge branch 'master' into jacobian_product_class
7cdfd2e
@albi3ro
Merge branch 'jacobian_product_class' into jpc-devices
079e887
@albi3ro
[skip ci] adding documentation and tests
0df2a56
@albi3ro albi3ro requested a review from dwierichs October 27, 2023 16:27
dwierichs
dwierichs reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@dwierichs dwierichs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @albi3ro! 🎉
Might make sense to rebase to autograd-use-jpc, or to native-jpc-devices, again after the auto-rebase?
Otherwise I only had some minor comments, and a changelog entry is needed :)

pennylane/devices/qubit/adjoint_jacobian.py Outdated Show resolved Hide resolved
pennylane/devices/execution_config.py Outdated Show resolved Hide resolved
pennylane/interfaces/torch.py Outdated Show resolved Hide resolved
pennylane/interfaces/torch.py Show resolved Hide resolved
tests/interfaces/default_qubit_2_integration/test_torch_default_qubit_2.py Outdated Show resolved Hide resolved
tests/interfaces/default_qubit_2_integration/test_torch_default_qubit_2.py Outdated Show resolved Hide resolved
tests/interfaces/test_torch.py Show resolved Hide resolved
pennylane/interfaces/execution.py Outdated Show resolved Hide resolved
@albi3ro albi3ro added the gpu label Nov 7, 2023
@albi3ro albi3ro removed the gpu label Nov 7, 2023
dwierichs
dwierichs approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good to go from my side! 🎉
Just two tiny things in the initial torch registration example.

pennylane/interfaces/torch.py Outdated Show resolved Hide resolved
pennylane/interfaces/torch.py Outdated Show resolved Hide resolved
albi3ro
albi3ro commented Nov 9, 2023
View reviewed changes
pennylane/interfaces/torch.py Outdated Show resolved Hide resolved
timmysilv
timmysilv reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweetness. just a few questions about what's going on

pennylane/interfaces/torch.py Outdated Show resolved Hide resolved
pennylane/interfaces/torch.py Show resolved Hide resolved
pennylane/interfaces/torch.py Outdated Show resolved Hide resolved
pennylane/interfaces/torch.py Show resolved Hide resolved
tests/interfaces/default_qubit_2_integration/test_torch_default_qubit_2.py Outdated Show resolved Hide resolved
@albi3ro @timmysilv
Apply suggestions from code review
247d73c 
Co-authored-by: Matthew Silverman <[email protected]>
timmysilv
timmysilv approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@albi3ro albi3ro enabled auto-merge (squash) November 13, 2023 15:51
@albi3ro albi3ro merged commit 1cea8c6 into master Nov 13, 2023
32 checks passed
@albi3ro albi3ro deleted the torch-use-jpc branch November 13, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trbromley trbromley trbromley left review comments

@dwierichs dwierichs dwierichs approved these changes

@timmysilv timmysilv timmysilv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@albi3ro @dwierichs @timmysilv @trbromley @mudit2812