make set_decomposition work on new device #4646
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4646 +/- ##
==========================================
- Coverage 99.63% 99.62% -0.01%
==========================================
Files 376 376
Lines 33665 33688 +23
==========================================
+ Hits 33541 33563 +22
- Misses 124 125 +1
☔ View full report in Codecov by Sentry. |
pennylane/transforms/tape_expand.py
Outdated
| @@ -350,6 +353,33 @@ def custom_decomp_expand(self, circuit, max_expansion=decomp_depth): | |||
| return custom_decomp_expand | |||
|
|
|||
|
|
|||
| @transform | |||
| def decomp_transform(tape: QuantumTape, custom_decomps: dict) -> (Sequence[QuantumTape], Callable): | |||
There was a problem hiding this comment.
Any worries about making this user facing? With a bit of polish, we can have this transform version available and think about deprecation of set_decomposition in 0.34.
There was a problem hiding this comment.
I also think polish, publicize, deprecate makes sense.
There was a problem hiding this comment.
How about custom_decomposition as the name?
|
Shall we close this PR with #4675 as a replacement? |
|
yep. |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: