Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyper parameters for tests in pulse module #4643

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

Qottmann
Copy link
Contributor

@Qottmann Qottmann commented Oct 4, 2023

Some hyper parameters can be reduced to speed up slow jax tests while maintaining coverage.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@Qottmann Qottmann requested a review from dwierichs October 4, 2023 09:35
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b45f808) 99.64% compared to head (8ce5eac) 99.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4643   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         376      376           
  Lines       33833    33833           
=======================================
  Hits        33712    33712           
  Misses        121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Thanks @Qottmann

@Qottmann Qottmann enabled auto-merge (squash) October 12, 2023 07:43
@Qottmann Qottmann merged commit 46b3603 into master Oct 17, 2023
38 checks passed
@Qottmann Qottmann deleted the pulsejaxtests branch October 17, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants