Hamiltonian support for Circuit Cutting #4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4642 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 376 376
Lines 33663 33672 +9
=======================================
+ Hits 33539 33548 +9
Misses 124 124
☔ View full report in Codecov by Sentry. |
mlxd
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Awesome work @obliviateandsurrender
I have a few small requests here
rmoyard
approved these changes
Oct 5, 2023
trbromley
reviewed
Oct 6, 2023
|
[sc-32504] |
albi3ro
reviewed
Oct 10, 2023
albi3ro
reviewed
Oct 10, 2023
mlxd
approved these changes
Oct 11, 2023
albi3ro
reviewed
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
qml.cut_circuitdoes not work for quantum circuits which computes the expectation values of Hamiltonians with more than one term.Description of the Change: Use
qml.transforms.hamiltonian_expandto extend support for Hamiltonians.Benefits: Circuit cutting could be used on more realistic circuits.
Possible Drawbacks: The Number of tapes to be computed increases and might give rise to possible overhead in the new scenario.
Related GitHub Issues: #3672