Add DeviceJacobianProducts jacobian product calculator
#4637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: David Wierichs <[email protected]>
dwierichs
approved these changes
Oct 12, 2023
dwierichs
reviewed
Oct 12, 2023
albi3ro
added a commit
that referenced
this pull request
Oct 19, 2023
This PR follows on from #4435 , and adds a child class that can handle device-provided derivatives. It has two private caches, `_results_cache` and `_jacs_cache`. This handles storing the jacobian between the forward pass and the backward pass. The caches will also store results and jacobians between successive calls to the same instance. The class can handle both device interfaces, `qml.Device` and `qml.devices.Device`. Name for the class is still up in the air. This class takes the full jacobian from the device and then performs the dot product. The class in #4637 takes the jacobian product itself from the device. --------- Co-authored-by: David Wierichs <[email protected]> Co-authored-by: Mudit Pandey <[email protected]>
mudit2812
added
the
merge-ready ✔️
mudit2812
added a commit
that referenced
this pull request
Oct 20, 2023
This PR follows on from #4435 , and adds a child class that can handle device-provided derivatives. It has two private caches, `_results_cache` and `_jacs_cache`. This handles storing the jacobian between the forward pass and the backward pass. The caches will also store results and jacobians between successive calls to the same instance. The class can handle both device interfaces, `qml.Device` and `qml.devices.Device`. Name for the class is still up in the air. This class takes the full jacobian from the device and then performs the dot product. The class in #4637 takes the jacobian product itself from the device. --------- Co-authored-by: David Wierichs <[email protected]> Co-authored-by: Mudit Pandey <[email protected]>
mudit2812
pushed a commit
that referenced
this pull request
Oct 20, 2023
This PR is a follow on to #4527 . [sc-44325] It adds `DeviceJacobianProducts` that can bind device provided jvps and vjps to the execution pipeline. --------- Co-authored-by: David Wierichs <[email protected]>
albi3ro
added a commit
that referenced
this pull request
Nov 7, 2023
This PR follows on from #4527 and #4637 . Since we still need to make performance improvements to `DefaultQubit.compute_vjp`, I added an opt-in keyword argument `use_device_jacobian_product` to `qml.execute`. This allows us to easily compare between using the device jacobian product and not. Fixes #3217 --------- Co-authored-by: David Wierichs <[email protected]> Co-authored-by: Tom Bromley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow on to #4527 . [sc-44325]
It adds
DeviceJacobianProductsthat can bind device provided jvps and vjps to the execution pipeline.