(LK-C-4) Add controlled QubitUnitary support to Lightning Kokkos #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
josephleekl
changed the title
josephleekl
force-pushed
the
lk-control-gate-NQ-multiRZ
branch
2 times, most recently
from
42f9cd3 to
23f398c
Compare
josephleekl
force-pushed
the
lk-control-matrix-NQ
branch
from
8807e39 to
07c38a1
Compare
josephleekl
added
ci:build_wheels
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lk-control-base #955 +/- ##
===================================================
+ Coverage 94.54% 96.08% +1.53%
===================================================
Files 231 231
Lines 37600 38191 +591
===================================================
+ Hits 35550 36695 +1145
+ Misses 2050 1496 -554 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
AmintorDusko
approved these changes
Nov 15, 2024
|
I'm running into some test errors with pennylane and |
|
Tests are passing with the merge now |
| @@ -436,6 +436,7 @@ class StateVectorKokkos final | |||
| matrix_trans, wires)); | |||
| break; | |||
| default: | |||
| // TODO: runtime determine scratch space level | |||
There was a problem hiding this comment.
Also the optimization on L0
There was a problem hiding this comment.
Updated the todo comment to clarify :)
multiphaseCFD
approved these changes
Nov 19, 2024
|
Thanks @maliasadi @multiphaseCFD @AmintorDusko ! |
5 tasks
josephleekl
added a commit
that referenced
this pull request
Dec 4, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [X] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [X] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [X] Ensure that the test suite passes, by running `make test`.
- [X] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [X] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
Native arbitrary controlled operations have already been implemented in
Lightning Qubit and Lightning GPU. This PR adds support for controlled
operations to Lightning Kokkos as well. This PR is the base branch of
combination of multiple PRs
([1](#952),
[2](#953),
[3](#954),
[4](#955),
[5](#956),
[6](#958),
[7](#965))
**Description of the Change:**
Controlled named-gates, matrix, generators, and adjoint differentiation
capability is added to Lightning Kokkos C++ layer.
**Benefits:**
Better performance for controlled operations in Lightning Kokkos (CPU +
GPU). Adjoint differentiation now supported in Lightning Kokkos.
**Possible Drawbacks:**
**Related GitHub Issues:**
[sc-78995]
---------
Co-authored-by: ringo-but-quantum <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
This PR adds support for controlled QubitUnitary for Lightning Kokkos. There are specialized implementations for 1/2/3-qubits (
applyNC1/2/3QubitOpFunctor) and a general case implementation (NCMultiQubitOpFunctor). These functors are defined inMatrixGateFunctors.hpp. These are called byapplyControlledMatrixorapplyOperation/applyNCMultiQubitOpinStateVectorKokkos.hppBenefits:
Performance benchmarks for gates are shown here: https://www.notion.so/xanaduai/Lightning-Kokkos-Native-Controlled-Operation-Gate-Benchmarks-12ebc6bd17648017a2dcd237748b24fe
Possible Drawbacks:
Related GitHub Issues:
[sc-76776]