Add `Mid-Measurement` support to single-GPU LGPU #931

multiphaseCFD · 2024-10-02T20:27:20Z

Before submitting

Please complete the following checklist when submitting a PR:

All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.
Ensure that the test suite passes, by running make test.
Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.
Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:

[SC-74842]

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Please complete the following checklist when submitting a PR: - [ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [x] Ensure that the test suite passes, by running `make test`. - [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [x] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** [SC-74668] `setStateVector` via state and wires is supported in the C++ layer in `lightning.gpu` **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: ringo-but-quantum <[email protected]>

codecov · 2024-10-09T00:13:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.99%. Comparing base (e1ec3ad) to head (00184e0).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
+ Coverage   96.24%   96.99%   +0.75%     
==========================================
  Files         215      132      -83     
  Lines       29473    17052   -12421     
==========================================
- Hits        28365    16540   -11825     
+ Misses       1108      512     -596

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LuisAlfredoNu

Thank you @multiphaseCFD
Nice feature addition to LGPU.
A few questions and suggestions.

mpitests/test_native_mcm.py

pennylane_lightning/core/src/simulators/lightning_gpu/tests/Test_StateVectorCudaManaged.cpp

pennylane_lightning/core/src/simulators/lightning_gpu/tests/mpi/Test_StateVectorCudaMPI.cpp

pennylane_lightning/lightning_gpu/_state_vector.py

pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp

pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp

pennylane_lightning/lightning_gpu/_state_vector.py

pennylane_lightning/lightning_gpu/lightning_gpu.py

LuisAlfredoNu

Thank you @multiphaseCFD
Just a few Q.

pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp

pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp

mpitests/test_native_mcm.py

maliasadi

Nice work @multiphaseCFD! Just a few comments before approving the PR.

mpitests/test_native_mcm.py

pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp

pennylane_lightning/core/src/simulators/lightning_gpu/bindings/LGPUBindings.hpp

pennylane_lightning/lightning_gpu/lightning_gpu.py

.github/CHANGELOG.md

maliasadi

LGTM! Just a few minor suggestions to apply before merge

pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp

pennylane_lightning/core/src/simulators/lightning_gpu/tests/Test_StateVectorCudaManaged.cpp

pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp

pennylane_lightning/lightning_gpu/lightning_gpu.py

LuisAlfredoNu

Nice job @multiphaseCFD
Thank you for expanding the features for LGPU
🚀

maliasadi

🎉

multiphaseCFD and others added 2 commits October 2, 2024 20:09

Initial commit

29cf4f0

Auto update version from '0.39.0-dev34' to '0.39.0-dev36'

0c449bf

multiphaseCFD changed the title ~~Initial commit~~ Add collapsed support LGPU C++ Oct 2, 2024

multiphaseCFD and others added 11 commits October 7, 2024 20:45

Merge branch 'master' into add_collapse_lgpu

1582064

Auto update version from '0.39.0-dev39' to '0.39.0-dev40'

6c36e5c

tidy up code and add mpi support

80c3a62

Auto update version from '0.39.0-dev40' to '0.39.0-dev41'

b2a3758

Auto update version from '0.39.0-dev40' to '0.39.0-dev41'

c7ea1a8

Merge branch 'master' into add_collapse_lgpu

208782f

Auto update version from '0.39.0-dev40' to '0.39.0-dev41'

829f8eb

update collapse with custatevec apis

2493260

Auto update version from '0.39.0-dev41' to '0.39.0-dev42'

4238aeb

add python layer

15c7e2f

multiphaseCFD changed the title ~~Add collapsed support LGPU C++~~ Add Mid-Measurement support to LGPU Oct 8, 2024

multiphaseCFD and others added 3 commits October 8, 2024 23:16

update changelog

6dc7c03

Merge branch 'master' into add_collapse_lgpu

5294b59

Auto update version from '0.39.0-dev41' to '0.39.0-dev42'

a57b5ee

multiphaseCFD added ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request ci:use-gpu-runner Enable usage of GPU runner for this Pull Request labels Oct 9, 2024

make format

d608f06

multiphaseCFD marked this pull request as ready for review October 9, 2024 00:11

multiphaseCFD added 2 commits October 9, 2024 15:26

drop mpi support for mid-measurement

63facdd

make format

53ec72b

multiphaseCFD requested review from maliasadi, LuisAlfredoNu and josephleekl October 9, 2024 17:00

LuisAlfredoNu reviewed Oct 9, 2024

View reviewed changes

test mpi support

410d694

multiphaseCFD and others added 5 commits October 10, 2024 13:52

Merge branch 'master' into add_collapse_lgpu

7d631f5

tidy up the code

6a010f1

revert mpi support

7f4c97f

Auto update version from '0.39.0-dev42' to '0.39.0-dev43'

85dc575

tidy up code

0e9f1db

multiphaseCFD requested review from LuisAlfredoNu, maliasadi and josephleekl and removed request for maliasadi and josephleekl October 10, 2024 18:19

LuisAlfredoNu reviewed Oct 11, 2024

View reviewed changes

pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp Outdated Show resolved Hide resolved

pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp Outdated Show resolved Hide resolved

mpitests/test_native_mcm.py Outdated Show resolved Hide resolved

maliasadi reviewed Oct 11, 2024

View reviewed changes

multiphaseCFD added 3 commits October 15, 2024 14:02

drop mpi implementation

aad13c9

Add todos

82b59e3

tidy up docstring

168b436

multiphaseCFD requested a review from LuisAlfredoNu October 15, 2024 14:58

update C++ layer

ab021b7

multiphaseCFD requested a review from maliasadi October 15, 2024 15:03

maliasadi changed the title ~~Add Mid-Measurement support to LGPU~~ Add Mid-Measurement support to single-GPU LGPU Oct 15, 2024

maliasadi requested changes Oct 15, 2024

View reviewed changes

update

19b3ce1

multiphaseCFD requested a review from maliasadi October 15, 2024 22:27

multiphaseCFD and others added 3 commits October 15, 2024 22:58

remove use_mpi api

44a3f77

Merge branch 'master' into add_collapse_lgpu

2ade110

Auto update version from '0.39.0-dev43' to '0.39.0-dev44'

00184e0

multiphaseCFD added the urgent Mark a pull request as high priority label Oct 15, 2024

LuisAlfredoNu approved these changes Oct 16, 2024

View reviewed changes

maliasadi approved these changes Oct 16, 2024

View reviewed changes

multiphaseCFD merged commit 1293b96 into master Oct 16, 2024
82 of 83 checks passed

multiphaseCFD deleted the add_collapse_lgpu branch October 16, 2024 13:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `Mid-Measurement` support to single-GPU LGPU #931

Add `Mid-Measurement` support to single-GPU LGPU #931

multiphaseCFD commented Oct 2, 2024 •

edited

Loading

codecov bot commented Oct 9, 2024 •

edited

Loading

LuisAlfredoNu left a comment

LuisAlfredoNu left a comment

maliasadi left a comment

maliasadi left a comment

LuisAlfredoNu left a comment

maliasadi left a comment

Add Mid-Measurement support to single-GPU LGPU #931

Add Mid-Measurement support to single-GPU LGPU #931

Conversation

multiphaseCFD commented Oct 2, 2024 • edited Loading

Before submitting

codecov bot commented Oct 9, 2024 • edited Loading

Codecov Report

LuisAlfredoNu left a comment

Choose a reason for hiding this comment

LuisAlfredoNu left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

LuisAlfredoNu left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

Add `Mid-Measurement` support to single-GPU LGPU #931

Add `Mid-Measurement` support to single-GPU LGPU #931

multiphaseCFD commented Oct 2, 2024 •

edited

Loading

codecov bot commented Oct 9, 2024 •

edited

Loading