Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test changes to account for 0.39 deprecations #912

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Test changes to account for 0.39 deprecations #912

merged 3 commits into from
Sep 17, 2024

Conversation

mudit2812
Copy link
Contributor

Updating some tests to account for various deprecations happening in pennylane for v0.39.

@mudit2812 mudit2812 marked this pull request as ready for review September 17, 2024 18:09
@maliasadi maliasadi added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Sep 17, 2024
maliasadi
maliasadi approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mudit2812! Happy to get it merged once all test CIs have passed 🟢

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.34%. Comparing base (410f8b8) to head (72d8137).
Report is 67 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (410f8b8) and HEAD (72d8137). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (410f8b8) HEAD (72d8137)
36 8
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
- Coverage   96.29%   86.34%   -9.95%     
==========================================
  Files         212       24     -188     
  Lines       29415     2255   -27160     
==========================================
- Hits        28324     1947   -26377     
+ Misses       1091      308     -783

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AmintorDusko
AmintorDusko approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mudit2812!

@maliasadi maliasadi added the urgent Mark a pull request as high priority label Sep 17, 2024
@mudit2812 mudit2812 merged commit 3718dd6 into master Sep 17, 2024
77 of 78 checks passed
@mudit2812 mudit2812 deleted the deps/0.39-fixes branch September 17, 2024 21:32
@mudit2812
Copy link
Contributor Author

[sc-73913]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmintorDusko AmintorDusko AmintorDusko approved these changes

@maliasadi maliasadi maliasadi approved these changes

Assignees
No one assigned
Labels
ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request urgent Mark a pull request as high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mudit2812 @maliasadi @AmintorDusko @ringo-but-quantum