Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the name of Lightning additional runners #910

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

maliasadi
Copy link
Member

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.44%. Comparing base (1b570e0) to head (0584869).
Report is 67 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1b570e0) and HEAD (0584869). Click for more details.

HEAD has 77 uploads less than BASE
Flag BASE (1b570e0) HEAD (0584869)
81 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #910       +/-   ##
===========================================
- Coverage   96.43%   29.44%   -66.99%     
===========================================
  Files         212       24      -188     
  Lines       29415     2255    -27160     
===========================================
- Hits        28366      664    -27702     
- Misses       1049     1591      +542     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @maliasadi ! Don't forget to add an entry to the changelog.

@maliasadi maliasadi merged commit 410f8b8 into master Sep 16, 2024
53 of 54 checks passed
@maliasadi maliasadi deleted the up_pl_additional_runners branch September 16, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants