Skip binaries in the docs build script #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
maliasadi
force-pushed
the
fix_preinstall_docs
branch
from
3cd42d4 to
12095e1
Compare
maliasadi
requested review from
vincentmr,
LuisAlfredoNu,
multiphaseCFD,
AmintorDusko and
tomlqc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #904 +/- ##
===========================================
- Coverage 96.23% 57.29% -38.95%
===========================================
Files 212 24 -188
Lines 28318 2255 -26063
===========================================
- Hits 27252 1292 -25960
+ Misses 1066 963 -103 ☔ View full report in Codecov by Sentry. |
vincentmr
approved these changes
Sep 11, 2024
AmintorDusko
approved these changes
Sep 11, 2024
multiphaseCFD
pushed a commit
that referenced
this pull request
Sep 11, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [ ] Ensure that the test suite passes, by running `make test`.
- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [ ] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
Skip the build of Lightning sims binaries and dev requirements for
pulbic documentations. This will speed up the build of docs from +3000
seconds to 700 seconds.
**Description of the Change:**
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
[sc-73505]
---------
Co-authored-by: ringo-but-quantum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Skip the build of Lightning sims binaries and dev requirements for pulbic documentations. This will speed up the build of docs from +3000 seconds to 700 seconds.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-73505]