Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Version #898

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Update Version #898

merged 1 commit into from
Sep 6, 2024

Conversation

maliasadi
Copy link
Member

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@maliasadi maliasadi merged commit 8c05022 into master Sep 6, 2024
33 of 35 checks passed
@maliasadi maliasadi deleted the maa-patch-1 branch September 6, 2024 20:31
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.66%. Comparing base (c676ced) to head (cebf777).
Report is 80 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c676ced) and HEAD (cebf777). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (c676ced) HEAD (cebf777)
14 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #898       +/-   ##
===========================================
- Coverage   95.55%   27.66%   -67.90%     
===========================================
  Files         208       20      -188     
  Lines       28227     2353    -25874     
===========================================
- Hits        26973      651    -26322     
- Misses       1254     1702      +448     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

multiphaseCFD pushed a commit that referenced this pull request Sep 8, 2024
### Before submitting

Please complete the following checklist when submitting a PR:

- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      [`tests`](../tests) directory!

- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [ ] Ensure that the test suite passes, by running `make test`.

- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
      change, and including a link back to the PR.

- [ ] Ensure that code is properly formatted by running `make format`. 

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


------------------------------------------------------------------------------------------------------------

**Context:**

**Description of the Change:**

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant