Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the
state_vector
,measurement
class andsimulate
method for the LightningGPU with the new device API #892Add the
state_vector
,measurement
class andsimulate
method for the LightningGPU with the new device API #892Changes from 18 commits
120bbed
bdf4daa
b05a6a4
5dac907
bfd0771
a1ff6c6
a0cfb1d
f472471
c7ac82d
6627913
6290953
219262b
bca1a74
0f8f957
a9ccf62
a99b6e8
0399f18
23d5696
585c313
5eee8eb
92089eb
196042a
b4ed1ae
695283b
1729d06
5819efc
2dbc7db
0630edf
3fa8409
af16b8d
0cb050f
54afeb5
ac87663
35270fb
f51cbb9
65e66e9
0472fdd
96728cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGPU has different behaviour in
probs
from LQ and LK. LGPU needs to perform an extra conversion of results due to cuQuantum returns as col-major orderings, so performing transpose on data for bit-index shuffle is needed.Check warning on line 24 in pennylane_lightning/lightning_gpu/_measurements.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_measurements.py#L24
Check warning on line 109 in pennylane_lightning/lightning_gpu/_measurements.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_measurements.py#L106-L109
Check warning on line 150 in pennylane_lightning/lightning_gpu/_measurements.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_measurements.py#L150
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new file and class will be used to keep the device implementation similar between LQ, LK, and LGPU. Also, in case of future implementation of MPI resources in other devices.
Check warning on line 22 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L22
Check warning on line 64 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L63-L64
Check warning on line 67 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L66-L67
Check warning on line 70 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L69-L70
Check warning on line 75 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L75
Check warning on line 80 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L78-L80
Check warning on line 85 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L83-L85
Check warning on line 92 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L92
Check warning on line 98 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L98
Check warning on line 102 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L101-L102
Check warning on line 105 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L104-L105
Check warning on line 111 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L110-L111
Check warning on line 119 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L116-L119
Check warning on line 121 in pennylane_lightning/lightning_gpu/_mpi_handler.py
Codecov / codecov/patch
pennylane_lightning/lightning_gpu/_mpi_handler.py#L121