Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetBasisState and SetState to lightning.kokkos #838

Closed

Conversation

erick-xanadu
Copy link
Contributor

@erick-xanadu erick-xanadu commented Aug 5, 2024

Context: In order for the StatePrep and BasisState optimizations be implemented, the kokkos device needs to be modified. Since the kokkos device is migrating to the pennylane-lightning repo, it is necessary that these changes are also in the pennylane-lightning repo.

Description of the Change: Copies over changes from Catalyst regarding kokkos into the pennylane-lightning repo.

Related GitHub Issues: PennyLaneAI/catalyst#955

Notes: The tests won't pass until the PR PennyLaneAI/catalyst#955 is merged, since it updates the Catalyst Quantum Device API.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.03%. Comparing base (619b807) to head (3a92870).
Report is 88 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (619b807) and HEAD (3a92870). Click for more details.

HEAD has 92 uploads less than BASE
Flag BASE (619b807) HEAD (3a92870)
97 5
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #838       +/-   ##
===========================================
- Coverage   98.53%   39.03%   -59.51%     
===========================================
  Files         116       32       -84     
  Lines       18510     2257    -16253     
===========================================
- Hits        18239      881    -17358     
- Misses        271     1376     +1105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erick-xanadu
Copy link
Contributor Author

Closed in favour of: #843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants