Removing the quimb backend from lightning.tensor
#737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietropaoloFrisoni
changed the title
quimb backend from lightning.tensor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #737 +/- ##
==========================================
- Coverage 88.20% 79.96% -8.24%
==========================================
Files 83 15 -68
Lines 11875 1742 -10133
==========================================
- Hits 10474 1393 -9081
+ Misses 1401 349 -1052 ☔ View full report in Codecov by Sentry. |
…ce' of https://github.com/PennyLaneAI/pennylane-lightning into removing_quimb_interface
mlxd
reviewed
May 21, 2024
|
Once the PR is update and green, I'll approve. |
multiphaseCFD
approved these changes
May 23, 2024
PietropaoloFrisoni
added a commit
to PennyLaneAI/pennylane
that referenced
this pull request
May 23, 2024
…ce in PL lightning (#5699) **Context:** This PR moves part of the `lightning.tensor` device from PennyLane lightning to PennyLane. Such a device was introduced originally in the following pull requests: [1](PennyLaneAI/pennylane-lightning#671) and [2](PennyLaneAI/pennylane-lightning#686). Due to requirements change, it has been decided to create an additional `default.tensor` device and move it to the PennyLane repository. Specifically, we move the `quimb` interface and the corresponding Python implementation of `lightning.tensor` into `default.tensor`. For reference, the PR removing such a component from `lightning.tensor` is [here](PennyLaneAI/pennylane-lightning#737). *Please note that the full documentation for such a device will be added in a following PR* **Description of the Change:** As above. **Benefits:** Having two separate devices simplifies the distinction between the C++ and the Python components. The relationship between `lightning.tensor` and `default.tensor` will be similar to that between `lightning.qubit` and `default.qubit`. **Possible Drawbacks:** None with the existing code, since this is a new quantum device. **Related GitHub Issues:** None. **Related Shortcut Stories:** [sc-63256] [sc-62979] --------- Co-authored-by: albi3ro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: This PR removes the
quimbbackend and the corresponding interface from thelightning.tensordevice. Instead, a newdefault.tensordevice has been introduced in PennyLane. Due to requirements change, it has been decided to create adefault.tensordevice and move it to the PennyLane repository.Description of the Change: As above.
Benefits: Having two separate devices simplifies the distinction between the C++ and the Python components. The relationship between
lightning.tensoranddefault.tensorwill be similar to that betweenlightning.qubitanddefault.qubit.Possible Drawbacks: As we are removing an interface from an existing device, all the codes using the
quimbinterface inlightning.tensornow should usedefault.tensor, which lives in a different repository.Related GitHub Issues: None.
Related Shortcut Stories:
[sc-63277]
[sc-62257]