-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NonParametric & Parametric Gates support to Lightning.Tensor #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiphaseCFD
requested review from
AmintorDusko and
maliasadi
and removed request for
maliasadi and
AmintorDusko
May 23, 2024 15:58
AmintorDusko
approved these changes
May 23, 2024
maliasadi
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Happy to discuss obs and measurements support in the next PR 🚀
pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCudaBase.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_tensor/tensor/CMakeLists.txt
Show resolved
Hide resolved
mlxd
reviewed
May 23, 2024
pennylane_lightning/core/src/simulators/lightning_tensor/tensor/CMakeLists.txt
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_tensor/tensor/base/TensorBase.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_tensor/tensor/base/TensorBase.hpp
Show resolved
Hide resolved
vincentmr
reviewed
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @multiphaseCFD , looking good!
pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCudaBase.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCudaBase.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCudaBase.hpp
Show resolved
Hide resolved
...ightning/core/src/simulators/lightning_tensor/tncuda/gates/tests/Test_MPSTNCuda_NonParam.cpp
Show resolved
Hide resolved
...ightning/core/src/simulators/lightning_tensor/tncuda/gates/tests/Test_MPSTNCuda_NonParam.cpp
Show resolved
Hide resolved
...ightning/core/src/simulators/lightning_tensor/tncuda/gates/tests/Test_MPSTNCuda_NonParam.cpp
Show resolved
Hide resolved
...e_lightning/core/src/simulators/lightning_tensor/tncuda/gates/tests/Test_MPSTNCuda_Param.cpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:build_wheels
Activate wheel building.
ci:use-multi-gpu-runner
Enable usage of Multi-GPU runner for this Pull Request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Add gate support to
cutensornet
backedlightning.tensor
. Note thatapplyOperations
in thecutensornet
backed backends only appends gate tensors to the compute graph.[SC-61954] & [SC-61956]
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: