Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ringo, please calm down #716

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

rashidnhm
Copy link
Collaborator

@rashidnhm rashidnhm commented May 6, 2024

Context: The update version script does not account to the release PR that bumps up the version above what's in master.

Description of the Change:
Add in a catch where if the version is higher than master AND a prerelease tag of dev0 exists, then do nothing.

Benefits:
Release work can continue.

Possible Drawbacks:

IMPORTANT NOTE: The changes for this PR will take affect AFTER it is merged due to how the ringo workflow does it's thing (using pull_request_target)

Related GitHub Issues:

Copy link
Contributor

github-actions bot commented May 6, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.40%. Comparing base (cc57f14) to head (af537fc).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #716       +/-   ##
===========================================
- Coverage   96.36%   52.40%   -43.96%     
===========================================
  Files         193       16      -177     
  Lines       26347     1765    -24582     
===========================================
- Hits        25389      925    -24464     
+ Misses        958      840      -118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label May 6, 2024
@maliasadi maliasadi merged commit cde3016 into master May 6, 2024
67 of 68 checks passed
@maliasadi maliasadi deleted the sc-62711-ringo-needs-to-calm-down branch May 6, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants