-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable gate dispatcher on x64 MacOS #697
Conversation
[sc-61797] |
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #697 +/- ##
==========================================
+ Coverage 98.58% 98.67% +0.09%
==========================================
Files 174 174
Lines 22629 22629
==========================================
+ Hits 22309 22330 +21
+ Misses 320 299 -21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too! But isn't this change going to disable the dispatcher on all MacOS platforms (not just x64)?
There's no dispatcher support on anything but x64, so it won't affect the ARM builds in any way, so I think it's fine. If we intend to add ARM intrinsics later, we'll need to restructure the dispatcher anyway, so that's probably the best time to re-evaluate. |
Ah, yes, of course. All good then. |
Thanks @vincentmr and @jay-selby |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: Due to intermittent failures on the CI, this PR disable the dynamic dispatcher on x64 MacOS builds of LightningQubit.
Description of the Change: As above.
Benefits: Ensures successful builds of the packages for testing and validation across ecosystem.
Possible Drawbacks:
Related GitHub Issues: