-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update serialization tests with PauliWord
order updates
#688
Conversation
Hello. You may have forgotten to update the changelog!
|
@mudit2812, I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nice to see this change @mudit2812 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mudit! No blocker from my side when these tests pass 🟢
https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/8804624819/job/24165412554?pr=688
* Fix native mcm workflow following dynamic_one_shot refactor. * Auto update version from '0.36.0-dev35' to '0.36.0-dev36' * Update changelog. --------- Co-authored-by: ringo-but-quantum <[email protected]>
Context:
Pennylane #5301 updates
PauliWord
to reorder differently when using the@
operator.Description of the Change:
test_serialize.py
to accommodate the change mentioned above.Also added tests forThese were removed and will be added in a future PR.device_vjp=True
with all interfaces. Not related to the above changes, but it's getting quite cumbersome to merge small changes multiple times.Not to be merged until Pennylane #5301 is merged.
Note for reviewers: since some CI overrides the
requirements-dev.txt
file and always usespennylane
from master, I've skipped CI for now until the PR needed for CI in this PR to pass are merged topennylane
. But I'd like to have approvals here before I merge that PR so that I can merge this PR as soon as possible after the merge as the changes will cause CI failures in other lightning PRsBenefits:
Possible Drawbacks:
Related GitHub Issues: