Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serialization tests with PauliWord order updates #688

Merged
merged 65 commits into from
Apr 24, 2024
Merged

Conversation

mudit2812
Copy link
Contributor

@mudit2812 mudit2812 commented Apr 17, 2024

Context:
Pennylane #5301 updates PauliWord to reorder differently when using the @ operator.

Description of the Change:

  • Update tests in test_serialize.py to accommodate the change mentioned above.
  • Also added tests for device_vjp=True with all interfaces. Not related to the above changes, but it's getting quite cumbersome to merge small changes multiple times. These were removed and will be added in a future PR.

Not to be merged until Pennylane #5301 is merged.

Note for reviewers: since some CI overrides the requirements-dev.txt file and always uses pennylane from master, I've skipped CI for now until the PR needed for CI in this PR to pass are merged to pennylane. But I'd like to have approvals here before I merge that PR so that I can merge this PR as soon as possible after the merge as the changes will cause CI failures in other lightning PRs

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@mudit2812 mudit2812 marked this pull request as ready for review April 22, 2024 14:47
@mudit2812 mudit2812 added the ci:build_wheels Activate wheel building. label Apr 22, 2024
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@AmintorDusko AmintorDusko added the do not merge Do not merge PR until this label is removed label Apr 22, 2024
@AmintorDusko
Copy link
Contributor

@mudit2812, I added do not merge label just in case.
Feel free to remove it as soon as PennyLaneAI/pennylane#5301 is merged.

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice to see this change @mudit2812 !

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mudit! No blocker from my side when these tests pass 🟢

https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/8804624819/job/24165412554?pr=688

@mudit2812 mudit2812 removed the do not merge Do not merge PR until this label is removed label Apr 23, 2024
* Fix native mcm workflow following dynamic_one_shot refactor.

* Auto update version from '0.36.0-dev35' to '0.36.0-dev36'

* Update changelog.

---------

Co-authored-by: ringo-but-quantum <[email protected]>
@maliasadi maliasadi merged commit 6efe874 into master Apr 24, 2024
83 checks passed
@maliasadi maliasadi deleted the pw-reorder branch April 24, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants