Add test_templates module + Fix LQ decomposition of StatePrep Ops + Fix LQ decomposition strategy of QFT and GroverOperator #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #684 +/- ##
==========================================
+ Coverage 96.12% 99.12% +2.99%
==========================================
Files 186 207 +21
Lines 24987 27607 +2620
==========================================
+ Hits 24020 27365 +3345
+ Misses 967 242 -725 ☔ View full report in Codecov by Sentry. |
AmintorDusko
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Very nice work, @vincentmr! I left some, not so important, suggestions and questions.
Not a blocker.
Co-authored-by: Amintor Dusko <[email protected]>
Co-authored-by: Amintor Dusko <[email protected]>
maliasadi
reviewed
Apr 17, 2024
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
maliasadi
approved these changes
Apr 17, 2024
* Fix bug; add tests; update changelog * Auto update version * Update tests * Update qft/grover decomp * Addressing code review * Update pennylane_lightning/lightning_qubit/lightning_qubit.py Co-authored-by: Ali Asadi <[email protected]> * Trigger CI * Auto update version --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ali Asadi <[email protected]>
maliasadi
added
the
ci:use-multi-gpu-runner
maliasadi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
In this PR,
Add
test_templates.pymodule where Grover and QSVT are tested. Resolving [sc-41770] requires adding a test for QSVT.(#684)
LightningQubitcorrectly decomposes state prep operations when used in the middle of a circuit.(#687)
LightningQubitcorrectly decomposesqml.QFTandqml.GroverOperatoriflen(wires)is greater than 9 and 12 respectively.(#687)
Description of the Change:
Add
test_templates.pymodule where Grover and QSVT are tested.Benefits:
Possible Drawbacks:
Related GitHub Issues: