Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CodeCov issue with compat-check actions #682

Merged
merged 11 commits into from
Apr 17, 2024
Merged

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Apr 15, 2024

This PR fixes the CodeCov job failures in compat-check actions by

  • Update the version of codecov-action from v3 to v4
  • Inherit the codecov token secret to extend the visibility of the token for compat-check actions
  • Suppress no-test ExitCode 5 from pytests for test_native_mcm labels until the next release of Lightning.

[sc-61507]

@maliasadi maliasadi requested a review from rashidnhm April 15, 2024 15:57
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (6d374fd) to head (085239f).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #682       +/-   ##
===========================================
+ Coverage   85.19%   97.43%   +12.23%     
===========================================
  Files          64      173      +109     
  Lines        9277    22617    +13340     
===========================================
+ Hits         7904    22036    +14132     
+ Misses       1373      581      -792     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maliasadi
Just 2 comments:

.github/workflows/tests_linux.yml Outdated Show resolved Hide resolved
@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Apr 16, 2024
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you, @maliasadi!

@maliasadi maliasadi merged commit 288b08d into master Apr 17, 2024
81 of 83 checks passed
@maliasadi maliasadi deleted the up_codecov_token branch April 17, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants