Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow_dispatch to wheels recipes #679

Merged
merged 26 commits into from
Apr 22, 2024
Merged

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Apr 12, 2024

  • Add workflow_dispatch to wheels recipes
  • Enable developers to build wheels manually on a branch instead of temporarily changing the headers
  • Update changelog

[sc-61640]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.61%. Comparing base (4bbee4d) to head (aace977).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #679      +/-   ##
==========================================
- Coverage   98.67%   98.61%   -0.07%     
==========================================
  Files         174      175       +1     
  Lines       22624    22639      +15     
  Branches        0      717     +717     
==========================================
  Hits        22325    22325              
- Misses        299      314      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmintorDusko
Copy link
Contributor

@maliasadi, could you please update the changelog?

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @maliasadi . As a follow-up, we might consider adding a cron job and report the status in plugin-test-matrix. Nothing to do for now.

@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Apr 12, 2024
@maliasadi maliasadi force-pushed the maa/gh_workflow_dispatch branch from 803601d to ef4cfad Compare April 12, 2024 18:56
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for adding a tag for PPC wheels building.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding my suggestion for uploading wheels as artifacts for workflow dispatch. With this, we'll be able to better inspect wheels when necessary.
Great Job.
Let's consider coming back to this when time allows and create an additional label for building the heavy wheels, this will improve development for such wheels.

@maliasadi maliasadi merged commit 43bed84 into master Apr 22, 2024
82 of 83 checks passed
@maliasadi maliasadi deleted the maa/gh_workflow_dispatch branch April 22, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants