-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow_dispatch to wheels recipes #679
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #679 +/- ##
==========================================
- Coverage 98.67% 98.61% -0.07%
==========================================
Files 174 175 +1
Lines 22624 22639 +15
Branches 0 717 +717
==========================================
Hits 22325 22325
- Misses 299 314 +15 ☔ View full report in Codecov by Sentry. |
@maliasadi, could you please update the changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @maliasadi . As a follow-up, we might consider adding a cron job and report the status in plugin-test-matrix. Nothing to do for now.
803601d
to
ef4cfad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for adding a tag for PPC wheels building.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding my suggestion for uploading wheels as artifacts for workflow dispatch. With this, we'll be able to better inspect wheels when necessary.
Great Job.
Let's consider coming back to this when time allows and create an additional label for building the heavy wheels, this will improve development for such wheels.
[sc-61640]