Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic openblas/lapack loading for win32 #666

Draft
wants to merge 498 commits into
base: master
Choose a base branch
from

Conversation

multiphaseCFD
Copy link
Member

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

vincentmr and others added 30 commits March 18, 2024 19:26
Co-authored-by: Amintor Dusko <[email protected]>
@multiphaseCFD multiphaseCFD added the ci:build_wheels Activate wheel building. label Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 70.96774% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 61.65%. Comparing base (0d3ae45) to head (6ae076f).

Files Patch % Lines
...nnylane_lightning/core/src/utils/UtilLinearAlg.hpp 64.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #666       +/-   ##
===========================================
- Coverage   95.90%   61.65%   -34.25%     
===========================================
  Files         172       31      -141     
  Lines       24344     2110    -22234     
===========================================
- Hits        23346     1301    -22045     
+ Misses        998      809      -189     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multiphaseCFD multiphaseCFD changed the title Add dynamic openblas/lapack linking for win32 Add dynamic openblas/lapack loading for win32 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants