Update the LQ new device API to work with Catalyst #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maliasadi
requested review from
vincentmr,
multiphaseCFD,
trbromley,
AmintorDusko,
erick-xanadu and
tomlqc
|
Hello. You may have forgotten to update the changelog!
|
vincentmr
reviewed
Mar 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 93.69% 97.65% +3.96%
==========================================
Files 173 173
Lines 24499 24509 +10
==========================================
+ Hits 22954 23934 +980
+ Misses 1545 575 -970 ☔ View full report in Codecov by Sentry. |
|
@maliasadi, we still have some tests failing, and the changelog needs to be updated. Could you please look into this? |
|
@AmintorDusko yeah, will update the PR after fixing the remaining issues in Catalyst :) |
maliasadi
force-pushed
the
maa/catalyst-work-with-new-device-api
branch
from
35af21e to
8e552c3
Compare
AmintorDusko
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Nice Job, @maliasadi. Let me know if you need more review here.
vincentmr
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Looks good to me, thanks @maliasadi . Glad to know Catalyst compatibility will be restored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #646 replaced the old device API with the new one for LQ. This migration and a few followup PRs break the Catalyst support for "lightning.qubit" against the master branch due to,
configdevice attribute,_num_burnin, andstopping_condition_shots.This PR fixes these issues.
[sc-59103]