Remove non-native observables from TOML files #659
Conversation
maliasadi
requested review from
vincentmr,
AmintorDusko,
erick-xanadu and
tomlqc
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #659 +/- ##
==========================================
+ Coverage 98.25% 98.47% +0.21%
==========================================
Files 172 63 -109
Lines 24709 9155 -15554
==========================================
- Hits 24277 9015 -15262
+ Misses 432 140 -292 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks good to me. Just a tiny thing, we could move Identity up the list with the other Hermitian gates and use the canonical order: gates, Hermitian, Hamiltonian, SparseHamiltonian. I mean canonical in the Lightning sense, that's usually the order in which they are listed.
|
@maliasadi just to double-check: are the new versions of toml configs compatible with the current Catalyst validation? |
**Context:** Quantum device config now contains only native observables (it means, handled by C-API), while the `device.observables` may contain additional non-native observables supported by the device Python API. **Description of the Change:** By this PR we relax the observables validation. **Benefits:** Fix support toml schema 2 configs. **Possible Drawbacks:** **Related GitHub Issues:** * PennyLaneAI/pennylane-lightning#659 * PennyLaneAI/pennylane-lightning#642 --------- Co-authored-by: erick-xanadu <[email protected]>
This PR removes non-native observables (those obs which are not supported natively by the device) from TOML files.