-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix Catalyst: add GlobalPhase in TOML files #615
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
==========================================
+ Coverage 91.04% 98.69% +7.65%
==========================================
Files 10 169 +159
Lines 1686 23934 +22248
==========================================
+ Hits 1535 23622 +22087
- Misses 151 312 +161 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Co-authored-by: Ali Asadi <[email protected]>
...htning/core/src/simulators/lightning_kokkos/gates/tests/Test_StateVectorKokkos_Generator.cpp
Show resolved
Hide resolved
...htning/core/src/simulators/lightning_kokkos/gates/tests/Test_StateVectorKokkos_Generator.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vincentmr
As a follow up, we can track whether the PS recipe needs specific handling for the GlobalPhase input parameter (which shouldn't be trainable).
…os and L-GPU.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Catalyst tests fail with
following the introduction of
GlobalPhase
support (#579).Description of the Change:
Add
GlobalPhase
in TOML files.Add tests that validate the adjoint method for all supported gates.
Add
GlobalPhase
generators in L-GPU and L-Kokkos.Benefits:
Possible Drawbacks:
Related GitHub Issues:
Bug fix update Catalyst TOML file [sc-56992]