-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C(MultiRZ) and C(Rot) gates #614
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #614 +/- ##
=======================================
Coverage 98.69% 98.70%
=======================================
Files 169 169
Lines 23934 24019 +85
=======================================
+ Hits 23622 23707 +85
Misses 312 312 ☔ View full report in Codecov by Sentry. |
Why is Codecov complaining over the new |
That program is just for testing the gate kernels. There is another program that tests the generators. When #579 gets merged, this should get covered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two fly-by comments, but ignore as needed
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
C(Rot) and C(MultiRZ) are required for Lightning QSVT support.
Description of the Change:
Add C(Rot) and C(MultiRZ).
Benefits:
Possible Drawbacks:
Related GitHub Issues:
Lightning Qubit implement C Rot gate [sc-56307]
Lightning Qubit implement C MultiRZ gate [sc-56311]