Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C(MultiRZ) and C(Rot) gates #614

Merged
merged 19 commits into from
Feb 23, 2024
Merged

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Feb 13, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
C(Rot) and C(MultiRZ) are required for Lightning QSVT support.

Description of the Change:
Add C(Rot) and C(MultiRZ).

Benefits:

Possible Drawbacks:

Related GitHub Issues:
Lightning Qubit implement C Rot gate [sc-56307]
Lightning Qubit implement C MultiRZ gate [sc-56311]

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9719855) 98.69% compared to head (d22d076) 98.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   98.69%   98.70%           
=======================================
  Files         169      169           
  Lines       23934    24019   +85     
=======================================
+ Hits        23622    23707   +85     
  Misses        312      312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr marked this pull request as ready for review February 13, 2024 21:01
@vincentmr vincentmr requested review from a team and tomlqc and removed request for mlxd and AmintorDusko February 15, 2024 14:01
@vincentmr vincentmr mentioned this pull request Feb 15, 2024
5 tasks
@tomlqc
Copy link
Contributor

tomlqc commented Feb 15, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Why is Codecov complaining over the new applyNCGeneratorMultiRZ() being not covered?
Isn't it the purpose of N-controlled MultiRZ in Test_GateImplementations_Param.cpp ?

@vincentmr
Copy link
Contributor Author

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Why is Codecov complaining over the new applyNCGeneratorMultiRZ() being not covered? Isn't it the purpose of N-controlled MultiRZ in Test_GateImplementations_Param.cpp ?

That program is just for testing the gate kernels. There is another program that tests the generators. When #579 gets merged, this should get covered.

@vincentmr vincentmr requested a review from tomlqc February 20, 2024 15:32
@vincentmr vincentmr requested a review from mlxd February 22, 2024 18:43
@vincentmr vincentmr changed the title Feature/controlled multirz Add C(MultiRZ) and C(Rot) gates Feb 23, 2024
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two fly-by comments, but ignore as needed

@vincentmr vincentmr merged commit 86f22a7 into master Feb 23, 2024
85 checks passed
@vincentmr vincentmr deleted the feature/controlled_multirz branch February 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants