-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove prep argument #542
remove prep argument #542
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #542 +/- ##
==========================================
- Coverage 99.00% 97.37% -1.64%
==========================================
Files 167 145 -22
Lines 22211 17322 -4889
==========================================
- Hits 21990 16867 -5123
- Misses 221 455 +234
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @albi3ro for dealing with this so quickly.
Codecov is failing expectedly because MPI coverage is lacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @albi3ro.
In #4756 : PennyLaneAI/pennylane#4756
the
prep
keyword argument was removed fromQuantumScript
, completing its deprecation cycle. Now state prep should be placed at the beginning of theops
queue.