Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove prep argument #542

Merged
merged 3 commits into from
Oct 31, 2023
Merged

remove prep argument #542

merged 3 commits into from
Oct 31, 2023

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Oct 31, 2023

In #4756 : PennyLaneAI/pennylane#4756

the prep keyword argument was removed from QuantumScript, completing its deprecation cycle. Now state prep should be placed at the beginning of the ops queue.

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@mlxd mlxd requested a review from a team October 31, 2023 20:06
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ce8597e) 99.00% compared to head (3e11ef5) 97.37%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
- Coverage   99.00%   97.37%   -1.64%     
==========================================
  Files         167      145      -22     
  Lines       22211    17322    -4889     
==========================================
- Hits        21990    16867    -5123     
- Misses        221      455     +234     
Files Coverage Δ
pennylane_lightning/core/_version.py 100.00% <100.00%> (ø)
pennylane_lightning/core/lightning_base.py 100.00% <100.00%> (ø)
pennylane_lightning/lightning_gpu/lightning_gpu.py 3.19% <0.00%> (-84.47%) ⬇️

... and 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @albi3ro for dealing with this so quickly.

@vincentmr
Copy link
Contributor

Codecov is failing expectedly because MPI coverage is lacking.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @albi3ro.

@albi3ro albi3ro merged commit d7af3c6 into master Oct 31, 2023
76 of 78 checks passed
@albi3ro albi3ro deleted the remove-prep branch October 31, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants