Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/catalyst enum #521

Merged
merged 8 commits into from
Oct 19, 2023
Merged

Bugfix/catalyst enum #521

merged 8 commits into from
Oct 19, 2023

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Oct 18, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
sc-47816

Description of the Change:
Revert GateOperation enum's BEGIN to start at 0. We then have to change the applyGenerator method of StateVectorKokkos to properly pass the throw test.

Benefits:

Possible Drawbacks:
applyGenerator a bit slower because we need to valid the op and throw.

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bce777) 97.74% compared to head (7f1b708) 99.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
+ Coverage   97.74%   99.34%   +1.60%     
==========================================
  Files         144      167      +23     
  Lines       17331    21918    +4587     
==========================================
+ Hits        16940    21775    +4835     
+ Misses        391      143     -248     
Files Coverage Δ
pennylane_lightning/core/_version.py 100.00% <100.00%> (ø)
.../simulators/lightning_kokkos/StateVectorKokkos.hpp 99.75% <100.00%> (ø)
...s/gates/tests/Test_StateVectorKokkos_Generator.cpp 100.00% <100.00%> (ø)
...os/gates/tests/Test_StateVectorKokkos_NonParam.cpp 100.00% <100.00%> (ø)

... and 45 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr marked this pull request as ready for review October 18, 2023 18:25
@vincentmr vincentmr requested review from maliasadi and mlxd October 18, 2023 18:25
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vincentmr!

@vincentmr vincentmr merged commit bd9af0f into master Oct 19, 2023
76 of 77 checks passed
@vincentmr vincentmr deleted the bugfix/catalyst_enum branch October 19, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants