Add LGPU with single GPU backend #499

multiphaseCFD · 2023-09-12T23:53:15Z

Before submitting

Please complete the following checklist when submitting a PR:

All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.
Ensure that the test suite passes, by running make test.
Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.
Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:

Add Ligtning-GPU to Pennylane-Lightning repo

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

* Add PL_BACKEND_LIST * Update the support * Exclude Python bindings * Update HermitianObs name scope conflicts * Auto update version * Cleanup * Update CI to build and check C++ tests of multiple backends (Linux) * Update changelog * Update .github/workflows/tests_linux.yml Co-authored-by: Vincent Michaud-Rioux <[email protected]> * Apply code review suggestions * Update .github/workflows/tests_linux.yml Co-authored-by: Amintor Dusko <[email protected]> --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <[email protected]> Co-authored-by: Amintor Dusko <[email protected]>

* Update DefaultQubit to DefaultQubitLegacy * Update changelog * update pylint disable on fallback

codecov · 2023-09-16T02:19:47Z

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (568a5b4) 99.09% compared to head (25f0880) 99.34%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   99.09%   99.34%   +0.24%     
==========================================
  Files         143      167      +24     
  Lines       17183    21918    +4735     
==========================================
+ Hits        17028    21775    +4747     
+ Misses        155      143      -12

Files	Coverage Δ
pennylane_lightning/core/_serialize.py	`100.00% <100.00%> (ø)`
pennylane_lightning/core/_version.py	`100.00% <100.00%> (ø)`
...ane_lightning/core/src/algorithms/JacobianData.hpp	`100.00% <100.00%> (ø)`
...core/src/algorithms/tests/Test_AdjointJacobian.cpp	`100.00% <100.00%> (ø)`
...e/src/measurements/tests/Test_MeasurementsBase.cpp	`100.00% <100.00%> (ø)`
...ng/core/src/observables/tests/Test_Observables.cpp	`100.00% <100.00%> (ø)`
...c/simulators/lightning_gpu/StateVectorCudaBase.hpp	`100.00% <100.00%> (ø)`
...rs/lightning_gpu/algorithms/AdjointJacobianGPU.hpp	`100.00% <100.00%> (ø)`
...g_gpu/algorithms/tests/Test_AdjointJacobianGPU.cpp	`100.00% <100.00%> (ø)`
...rc/simulators/lightning_gpu/gates/cuGates_host.hpp	`100.00% <100.00%> (ø)`
... and 24 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/test_gpu_cu11.yml

vincentmr

Pretty much done, cheers!

pennylane_lightning/core/src/simulators/lightning_gpu/CMakeLists.txt

pennylane_lightning/core/src/simulators/lightning_gpu/gates/cuGates_host.hpp

.github/CHANGELOG.md

vincentmr

I left a suggestion for the changelog (feel free to add more), but I'm happy to approve.

mlxd

Thanks folks --- some questions and suggestions

pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuda_helpers.hpp

.github/workflows/tests_gpu_cu11.yml

pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp

pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuda_helpers.hpp

pennylane_lightning/lightning_gpu/lightning_gpu.py

tests/test_measurements_sparse.py

mlxd

Approved, but feel free to remove that last added line before merging

pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuda_helpers.hpp

multiphaseCFD · 2023-10-18T18:20:58Z

Thanks @mlxd and @vincentmr for reviewing this 15k lines PR!

This fixes the issue with building `StateVectorLQubitDynamic` against the master branch of the lightning monorepo after merging PR PennyLaneAI/pennylane-lightning#499.

multiphaseCFD and others added 16 commits September 12, 2023 16:52

add LGPU cpp layer

15e42fd

update measurement

ece63c6

add openmp to adjgpu

9431ef6

Merge branch 'master' into add_LGPU

44237ea

Auto update version

39d144e

add python layer & isingxy gate in the cpp layer

5b2220d

add batched adjoint method

b10494b

Update DefaultQubit to DefaultQubitLegacy (#500)

62ee28b

* Update DefaultQubit to DefaultQubitLegacy * Update changelog * update pylint disable on fallback

Auto update version

d921b4f

add batch support for adjoint method

cd06aa6

add gitignore

38bfad3

tidy up code

516447f

Merge branch 'master' into add_LGPU

8de101a

Auto update version

c7d6012

make format

6bcd87c

multiphaseCFD added 13 commits September 18, 2023 06:03

revert complexT delete in LKokkosBingds

c9cbdaa

make format

108e1fe

update based on tidy

d94fc0e

fix tidy format

ee914a2

add_gpu_runners_tests

e1a9bb0

add cuquantum_sdk path to ci workflow

ce49548

debug

a99363c

add path to cuquantum sdk

ad4b938

add python layer tests in ci workflow

78bab88

ci tests

3c9e9c0

quick fix

b805ec2

skip pr ci for some workflows

08412c4

quick fix

f0dc631

multiphaseCFD requested a review from mlxd October 17, 2023 14:38

vincentmr reviewed Oct 17, 2023

View reviewed changes

.github/workflows/test_gpu_cu11.yml Outdated Show resolved Hide resolved

vincentmr reviewed Oct 17, 2023

View reviewed changes

multiphaseCFD added 2 commits October 17, 2023 15:30

add changelog and matrixhasher

61ba81a

quick update

5be027b

multiphaseCFD requested a review from vincentmr October 17, 2023 16:40

vincentmr reviewed Oct 17, 2023

View reviewed changes

.github/CHANGELOG.md Outdated Show resolved Hide resolved

vincentmr approved these changes Oct 17, 2023

View reviewed changes

mlxd requested changes Oct 17, 2023

View reviewed changes

multiphaseCFD added 11 commits October 17, 2023 20:14

tidy up code and add more tests

6bc75d7

add more unit tests for algorithm

5f20309

more unit tests in py layer

76e5783

add adjoint tests for sparseH

2a3dab9

make format

0974aa2

quick fix

72f07d1

quick fix

bc998fd

another fix

967bea2

fix

c26c109

fix codecov complaints

fb8a017

resolve comments

16dd415

multiphaseCFD requested a review from mlxd October 18, 2023 12:48

add appropriate license

9c6e08f

mlxd approved these changes Oct 18, 2023

View reviewed changes

pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuda_helpers.hpp Outdated Show resolved Hide resolved

multiphaseCFD added 2 commits October 18, 2023 18:09

tidy up

e867229

quick fix

25f0880

multiphaseCFD merged commit 0bce777 into master Oct 18, 2023
72 checks passed

multiphaseCFD deleted the add_LGPU branch October 18, 2023 19:05

maliasadi mentioned this pull request Oct 18, 2023

[Runtime] Fixes the issue with missing CFP_t PennyLaneAI/catalyst#322

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add LGPU with single GPU backend #499

Add LGPU with single GPU backend #499

multiphaseCFD commented Sep 12, 2023 •

edited by mlxd

Loading

codecov bot commented Sep 16, 2023 •

edited

Loading

vincentmr left a comment

vincentmr left a comment

mlxd left a comment

mlxd left a comment

multiphaseCFD commented Oct 18, 2023 •

edited

Loading

Add LGPU with single GPU backend #499

Add LGPU with single GPU backend #499

Conversation

multiphaseCFD commented Sep 12, 2023 • edited by mlxd Loading

Before submitting

codecov bot commented Sep 16, 2023 • edited Loading

Codecov Report

vincentmr left a comment

Choose a reason for hiding this comment

vincentmr left a comment

Choose a reason for hiding this comment

mlxd left a comment

Choose a reason for hiding this comment

mlxd left a comment

Choose a reason for hiding this comment

multiphaseCFD commented Oct 18, 2023 • edited Loading

multiphaseCFD commented Sep 12, 2023 •

edited by mlxd

Loading

codecov bot commented Sep 16, 2023 •

edited

Loading

multiphaseCFD commented Oct 18, 2023 •

edited

Loading