-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding unit test for measurement with shots for LT with tn
method
#1027
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
- Coverage 97.93% 92.42% -5.51%
==========================================
Files 233 112 -121
Lines 39910 16923 -22987
==========================================
- Hits 39084 15641 -23443
- Misses 826 1282 +456 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LuisAlfredoNu .Please add this PR to changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @LuisAlfredoNu
Context:
With Lightning Tensor, ensure
tn
has feature parity withmps
method.Description of the Change:
Using the current testing suite for measurement, we change only the
conftest.py
file to make available thetn
method with Lightning TensorBenefits:
Change only a few lines in the code.
Possible Drawbacks:
The testing time will increase double for Lightning Tensor 😞
Related GitHub Issues:
[sc-65726]