Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit test for measurement with shots for LT with tn method #1027

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

LuisAlfredoNu
Copy link
Contributor

Context:
With Lightning Tensor, ensure tn has feature parity with mps method.

Description of the Change:
Using the current testing suite for measurement, we change only the conftest.py file to make available the tn method with Lightning Tensor

Benefits:
Change only a few lines in the code.

Possible Drawbacks:
The testing time will increase double for Lightning Tensor 😞

Related GitHub Issues:

[sc-65726]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (1782bbd) to head (5c2ac01).
Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1782bbd) and HEAD (5c2ac01). Click for more details.

HEAD has 55 uploads less than BASE
Flag BASE (1782bbd) HEAD (5c2ac01)
64 9
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
- Coverage   97.93%   92.42%   -5.51%     
==========================================
  Files         233      112     -121     
  Lines       39910    16923   -22987     
==========================================
- Hits        39084    15641   -23443     
- Misses        826     1282     +456     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuisAlfredoNu LuisAlfredoNu added the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Dec 17, 2024
@LuisAlfredoNu LuisAlfredoNu marked this pull request as ready for review December 17, 2024 18:48
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuisAlfredoNu .Please add this PR to changelog.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

tests/lightning_qubit/test_measurements_class.py Outdated Show resolved Hide resolved
Copy link
Contributor

@josephleekl josephleekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @LuisAlfredoNu

@LuisAlfredoNu LuisAlfredoNu merged commit 4ddcdf2 into master Dec 18, 2024
70 of 71 checks passed
@LuisAlfredoNu LuisAlfredoNu deleted the add_exatn_shots branch December 18, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-gpu-runner Enable usage of GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants