Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LK CUDA CI issue #1020

Draft
wants to merge 46 commits into
base: master
Choose a base branch
from
Draft

fix LK CUDA CI issue #1020

wants to merge 46 commits into from

Conversation

josephleekl
Copy link
Contributor

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@josephleekl josephleekl added the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.25%. Comparing base (e6827b2) to head (febb136).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...tning_kokkos/catalyst/LightningKokkosSimulator.hpp 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e6827b2) and HEAD (febb136). Click for more details.

HEAD has 33 uploads less than BASE
Flag BASE (e6827b2) HEAD (febb136)
39 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1020       +/-   ##
===========================================
- Coverage   97.92%   78.25%   -19.68%     
===========================================
  Files         233      166       -67     
  Lines       39651    20606    -19045     
===========================================
- Hits        38828    16125    -22703     
- Misses        823     4481     +3658     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephleekl josephleekl added ci:use-gpu-runner Enable usage of GPU runner for this Pull Request draft Indicates that the PR is still in draft mode, but needs CIs. and removed ci:use-gpu-runner Enable usage of GPU runner for this Pull Request labels Dec 6, 2024
@josephleekl josephleekl marked this pull request as ready for review December 6, 2024 15:54
@josephleekl josephleekl added the ci:build_wheels Activate wheel building. label Dec 6, 2024
@josephleekl josephleekl removed ci:build_wheels Activate wheel building. draft Indicates that the PR is still in draft mode, but needs CIs. labels Dec 6, 2024
@josephleekl josephleekl marked this pull request as draft December 6, 2024 22:10
@josephleekl josephleekl added ci:use-gpu-runner Enable usage of GPU runner for this Pull Request draft Indicates that the PR is still in draft mode, but needs CIs. and removed ci:use-gpu-runner Enable usage of GPU runner for this Pull Request labels Dec 6, 2024
@josephleekl josephleekl marked this pull request as ready for review December 6, 2024 22:12
@josephleekl josephleekl added the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Dec 12, 2024
@josephleekl josephleekl marked this pull request as draft December 16, 2024 23:41
@josephleekl josephleekl added the WIP Work-in-progress issue. Not for general fixing. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-gpu-runner Enable usage of GPU runner for this Pull Request draft Indicates that the PR is still in draft mode, but needs CIs. WIP Work-in-progress issue. Not for general fixing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants