Ensure an ion.yield operation is returning a region output to all parallal protocol ops
#1475
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rallal protocol ops
|
Hello. You may have forgotten to update the changelog!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: During
quantum-to-ionpass, when decomposing RX, RY and MS gates to pulses in aParallelProtocolOp's region, the region was terminated with yield ops without any operands. This means no SSA values were actually yielded from the region. At the same time,ParallelProtocolOpreturns (variadic-length) values of type!quantum.bit. This means the IR is ill-formed.Description of the Change:
Ensure that all
ParallelProtocolOps will yield the input-ed qubit SSA values by doing so in the builder, when building the region of theParallelProtocolOp.Benefits: mlir is no longer ill-formed; increased readability