Allow quantum registers returned from functions during buffer deallocation #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
dime10
added
the
author:build-wheels
erick-xanadu
reviewed
Jan 6, 2025
| @@ -75,10 +82,12 @@ llvm: | |||
| -DCMAKE_CXX_VISIBILITY_PRESET=$(SYMBOL_VISIBILITY) | |||
|
|
|||
| # TODO: when updating LLVM, test to see if mlir/unittests/Bytecode/BytecodeTest.cpp:55 is passing | |||
| # and remove filter | |||
| LIT_FILTER_OUT="Bytecode" cmake --build $(LLVM_BUILD_DIR) --target check-mlir llvm-symbolizer | |||
| # and remove filter. This tests fails on CI/CD not locally. | |||
There was a problem hiding this comment.
Suggested change
| # and remove filter. This tests fails on CI/CD not locally. | |
| # and remove filter. These tests fails on CI/CD not locally. |
dime10
force-pushed
the
buffer-deallocation-patch
branch
from
2a772be to
f9f4e84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: This patch fixes a bug in upstream MLIR that prevents buffer deallocation from working in certain cases. The patch was also submitted upstream: llvm/llvm-project#121582
Description of the Change: This PR adds a patch to the llvm-project source, and updates the relevant build recipes. The llvm step during wheel builds is now also handled through Make instead of replicating the CMake configuration in each wheel script.
Benefits: Unblocks our friends over at Qrisp.
Possible Drawbacks: Patching dependencies is not great, but hopefully temporary.
Related GitHub Issues:
[sc-81444]