-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from_plxpr
to use PlxprInterpreter
base class
#1398
Open
albi3ro
wants to merge
18
commits into
main
Choose a base branch
from
update-from-plxpr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+158
−269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feel free to tag me for review when it's ready :) |
albi3ro
commented
Jan 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
==========================================
- Coverage 96.68% 96.61% -0.07%
==========================================
Files 75 75
Lines 8266 8222 -44
Branches 867 854 -13
==========================================
- Hits 7992 7944 -48
- Misses 221 224 +3
- Partials 53 54 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
When
from_plxpr
was added, we did not have any other plxpr interpreters or frameworks for them. Now we have thePlxprInterpreter
class that handles a lot of the infrastructure for converting plxpr to catalxpr.Description of the Change:
Uses the
PlxprInterpreter
class to cut down on repeated code and infrastructure in thefrom_plxpr
implementation. This also makes it to the interpreters follow the same pattern as other plxpr interpreters.Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-81469]