Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from_plxpr to use PlxprInterpreter base class #1398

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Dec 30, 2024

Context:

When from_plxpr was added, we did not have any other plxpr interpreters or frameworks for them. Now we have the PlxprInterpreter class that handles a lot of the infrastructure for converting plxpr to catalxpr.

Description of the Change:

Uses the PlxprInterpreter class to cut down on repeated code and infrastructure in the from_plxpr implementation. This also makes it to the interpreters follow the same pattern as other plxpr interpreters.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-81469]

@dime10
Copy link
Contributor

dime10 commented Dec 30, 2024

Feel free to tag me for review when it's ready :)

.dep-versions Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 91.46341% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.61%. Comparing base (4ec0a4e) to head (687129a).

Files with missing lines Patch % Lines
frontend/catalyst/from_plxpr.py 91.46% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
- Coverage   96.68%   96.61%   -0.07%     
==========================================
  Files          75       75              
  Lines        8266     8222      -44     
  Branches      867      854      -13     
==========================================
- Hits         7992     7944      -48     
- Misses        221      224       +3     
- Partials       53       54       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants