Add enable-debug-info flag in catalyst #1331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added enable-debug-info option in compilerOptions Fix user function location in the generated mlir
joeycarter
reviewed
Nov 27, 2024
| @@ -52,7 +52,7 @@ | |||
|
|
|||
|
|
|||
| @debug_logger | |||
| def jaxpr_to_mlir(func_name, jaxpr): | |||
| def jaxpr_to_mlir(func_name, jaxpr, func_loc=None): | |||
There was a problem hiding this comment.
Can you add func_loc to the list of Args in the docstring below?
| @@ -553,7 +553,7 @@ def trace_to_jaxpr(func, static_argnums, abstracted_axes, args, kwargs): | |||
|
|
|||
|
|
|||
| @debug_logger | |||
| def lower_jaxpr_to_mlir(jaxpr, func_name): | |||
| def lower_jaxpr_to_mlir(jaxpr, func_name, func_loc=None): | |||
erick-xanadu
requested changes
Nov 28, 2024
| @@ -244,6 +244,22 @@ def func(): | |||
|
|
|||
| func.workspace.cleanup() | |||
|
|
|||
| def test_debug_info(self, capsys): | |||
There was a problem hiding this comment.
Can you change this to be a lit test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Currently debug info is not propagated from JAX to LLVM making it.
Description of the Change:
This PR adds a qjit option "enable_debug_info" that adds the debug info to the intermediate IRs.
Benefits:
Intermediate IR files can now be created with debug info.
Possible Drawbacks:
the large number of MLIR passed that modify the IR may distort the debug info, so it may lose accuracy.
Related GitHub Issues:
[sc-73579]