Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLIR] Enable Multithreading compilation #1319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erick-xanadu
Copy link
Contributor

@erick-xanadu erick-xanadu commented Nov 20, 2024

Context: Now that catalyst cli is its own subprocess, we have a more graceful failing mechanism. Let's fuzz the multithreading aspects of catalyst while there is no rush for the next release.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-78851]

@erick-xanadu erick-xanadu added the reviewer:require-wheels Pull Requests will need wheel building job successful before being merged label Nov 20, 2024
@erick-xanadu erick-xanadu force-pushed the eochoa/2024-11-20/multithreaded-compilation branch from 2f2b078 to 581ecac Compare November 20, 2024 17:50
@erick-xanadu erick-xanadu added the author:build-wheels Run the wheel building workflows on this Pull Request label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.39%. Comparing base (e3266de) to head (581ecac).

Additional details and impacted files
@@            Coverage Diff             @@
##            main    #1319       +/-   ##
==========================================
+ Coverage   0.37%   81.39%   +81.01%     
==========================================
  Files         17       74       +57     
  Lines       1346     8195     +6849     
  Branches      73      858      +785     
==========================================
+ Hits           5     6670     +6665     
- Misses      1341     1468      +127     
- Partials       0       57       +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mehrdad2m
Copy link
Contributor

I remember when looking into the mlir-opt code, I found that they have warned against enabling it in general because it can potentially cause problem or slow down when parsing and also printing IR. So maybe just enabling it right before running the pass manager is safer. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author:build-wheels Run the wheel building workflows on this Pull Request reviewer:require-wheels Pull Requests will need wheel building job successful before being merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants